More tools for dual energy matching #247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nneveu
reviewed
Mar 6, 2025
| L1: REFS:BC1B:400:EDES | ||
| L2: REFS:BC2B:500:EDES | ||
| L3: REFS:BYP:400:EDES | ||
| L3: REFS:DMP?:400:EDES |
Member
There was a problem hiding this comment.
Is there really a question mark in this PV name?
Contributor
Author
There was a problem hiding this comment.
No. Code picks one undulator PV depending on beam code and destination.
nneveu
approved these changes
Mar 6, 2025
Member
nneveu
left a comment
nneveu
left a comment
There was a problem hiding this comment.
These changes look ok to me, feel free to merge. Sarah added a new linter (ruff), one of us can help you with that, just let me know.
Collaborator
|
Moving to internal PR #251 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tools for energy gain in dual energy matching mode. The Dump energy PV needs to be determined dynamically depending on primary/secondary beam path.